MAINT: remove unsupported roq json weight file format#945
Merged
Conversation
ColmTalbot
added
roq
ColmTalbot
commented
May 15, 2025
Collaborator
|
I don't think the numpy format should be removed. I use that format almost exclusively when running ROQ analyses with bilby, split between a weight calculation step and sampling step. |
ColmTalbot
force-pushed
the
remove-roq-json
branch
from
6d902c7 to
4567d60
Compare
asb5468
reviewed
Jul 9, 2025
mj-will
requested changes
Sep 29, 2025
mj-will
left a comment
mj-will
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, just a version that needs bumping.
Co-authored-by: Michael J. Williams <michaeljw1@googlemail.com>
mj-will
approved these changes
Sep 29, 2025
mattpitkin
reviewed
Oct 2, 2025
mattpitkin
approved these changes
Oct 2, 2025
mj-will
added a commit
to mj-will/bilby
that referenced
this pull request
Oct 16, 2025
* MAINT: remove unsupported roq json weight file format * BUG: CI fixes * DEP: restore npz weight format * TYPO: add missing line * TST: fix broken test * Revert some changes raised in review * Update removal version in docs Co-authored-by: Michael J. Williams <michaeljw1@googlemail.com> * DOC: fix json roq weight removal version --------- Co-authored-by: Michael J. Williams <michaeljw1@googlemail.com>
mj-will
added a commit
to mj-will/bilby
that referenced
this pull request
Feb 19, 2026
* MAINT: remove unsupported roq json weight file format * BUG: CI fixes * DEP: restore npz weight format * TYPO: add missing line * TST: fix broken test * Revert some changes raised in review * Update removal version in docs Co-authored-by: Michael J. Williams <michaeljw1@googlemail.com> * DOC: fix json roq weight removal version --------- Co-authored-by: Michael J. Williams <michaeljw1@googlemail.com>
fgittins
pushed a commit
to fgittins/bilby
that referenced
this pull request
Mar 5, 2026
* MAINT: remove unsupported roq json weight file format * BUG: CI fixes * DEP: restore npz weight format * TYPO: add missing line * TST: fix broken test * Revert some changes raised in review * Update removal version in docs Co-authored-by: Michael J. Williams <michaeljw1@googlemail.com> * DOC: fix json roq weight removal version --------- Co-authored-by: Michael J. Williams <michaeljw1@googlemail.com>
isaaclegred
pushed a commit
to isaaclegred/bilby
that referenced
this pull request
Mar 7, 2026
* MAINT: remove unsupported roq json weight file format * BUG: CI fixes * DEP: restore npz weight format * TYPO: add missing line * TST: fix broken test * Revert some changes raised in review * Update removal version in docs Co-authored-by: Michael J. Williams <michaeljw1@googlemail.com> * DOC: fix json roq weight removal version --------- Co-authored-by: Michael J. Williams <michaeljw1@googlemail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was slated for v2.2, but I guess we missed that...